Refactor OverloadIntegrationTest #17530
Merged
yanavlasov merged 1 commit intoenvoyproxy:mainfrom Aug 4, 2021
Merged
Conversation
resource monitors. Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
Contributor
Author
|
/assign @antoniovicente PTAL, if you have time. |
|
🙀 Error while processing event: |
Contributor
Author
|
/assign @antoniovicente PTAL, if you have time. |
antoniovicente
approved these changes
Aug 3, 2021
Contributor
|
Change is a pure test infrastructure only refactor and looks good. Only comment is if it would be worth extending OverloadIntegrationTest with additional options instead of extracting out some of these classes. It's hard to tell the best approach without looking at how this will be used in the future. |
Contributor
Author
|
Thanks for the review @antoniovicente. See: |
yanavlasov
approved these changes
Aug 4, 2021
baojr
added a commit
to baojr/envoy
that referenced
this pull request
Aug 4, 2021
…bridge-stream * upstream/main: (32 commits) tls: move ssl connection info into SocketAddressProvider (envoyproxy#17334) conn pool: default enable runtime feature `conn_pool_delete_when_idle` (envoyproxy#17577) api: LEDS api introduction (envoyproxy#17419) kafka: add support for api versions request in mesh-filter (envoyproxy#17475) ext_proc: Implement BUFFERED_PARTIAL processing mode (envoyproxy#17531) tooling: Async/pathlib/mypy cleanups and utils (envoyproxy#17505) xds: restructure CertificateProvider fields (envoyproxy#17201) Refactor OverloadIntegrationTest breaking out a test base, and the fake resource monitors. (envoyproxy#17530) listener: move active connection collection out of active tcp listener (envoyproxy#16947) tools: format checks for backticks (envoyproxy#17566) coverage: set lower limit for common/quic and common (envoyproxy#17573) v2: final source removal (envoyproxy#17565) test: bumping coverage (envoyproxy#17564) quic: enforcing header size and contents (envoyproxy#17520) Support for canonicalizing URI properly for AWS SigV4 signer (envoyproxy#17137) listener: add a stat for transport socket connect timeout (envoyproxy#17458) listener: add listen() error handling (envoyproxy#17427) http: return per route config when direct response is set (envoyproxy#17449) removing most v2 references from source/ (envoyproxy#17415) bug fix: return bootstrap when validating config (envoyproxy#17499) ... Signed-off-by: Garrett Bourg <bourg@squareup.com>
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
…ke resource monitors. (envoyproxy#17530) Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor OverloadIntegrationTest breaking out a test base, and the fake resource monitors.
Signed-off-by: Kevin Baichoo kbaichoo@google.com
Commit Message:Refactor OverloadIntegrationTest breaking out a test base, and the fake resource monitors.
Additional Description: These will be used in integration tests for checking that the reset stream mechanism kicks in based on Overload, resetting client streams.
Risk Level: low (test only)
Testing: ran tests (just a refactor)
Docs Changes: NA
Release Notes: NA
Platform Specific Features:NA
Related Issue: #15791